Skip to content

feat: color updates #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2025
Merged

feat: color updates #10

merged 1 commit into from
Oct 29, 2025

Conversation

@planetabhi
Copy link
Member

@planetabhi planetabhi commented Oct 29, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Version bumped to 2.1.0

  • Style

    • Updated grey color palette across all theme variants (dark-cold, dark-warm, light-cold, light-warm) for improved visual consistency and contrast

@coderabbitai
Copy link

coderabbitai bot commented Oct 29, 2025 •
edited
Loading

Walkthrough

The PR increments the color package version to 2.1.0 and updates the grey color scale (--grey1 through --grey10) across all four theme variants (dark-cold, dark-warm, light-cold, light-warm) with new OKLCH color values, adjusting lightness, chroma, and hue parameters throughout.

Changes

Cohort / File(s) Summary
Version Management
packages/colors/package.json		 Version bumped from 2.0.2 to 2.1.0
Color Theme Grey Scales
packages/colors/src/_theme-dark--cold.scss, packages/colors/src/_theme-dark--warm.scss, packages/colors/src/_theme-light--cold.scss, packages/colors/src/_theme-light--warm.scss		 All four theme files updated with new grey color palette (--grey1 through --grey10 values); OKLCH color values modified for lightness, chroma, and hue; dependent theme aliases (--cold* and --warm* variables) now map to refreshed grey scale

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas requiring extra attention:

  • Verify each of the 40 grey color value declarations (10 per file × 4 files) for correctness and consistency across all theme variants
  • Confirm visual design alignment of the new grey palette across light and dark themes
  • Validate that the OKLCH hue, chroma, and lightness adjustments achieve intended perceptual uniformity across all theme combinations

Poem

🐰 From grey to grey, a palette reformed,
Four themes dance in OKLCH's form,
Light and dark in harmony blend,
Chroma and hue, where colors transcend,
Version 2.1 brings fresh design to the end! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "feat: color updates" accurately reflects the main focus of the changeset. The pull request primarily modifies color token definitions across four theme files (dark-cold, dark-warm, light-cold, and light-warm), along with a minor version bump in package.json. The title clearly identifies color-related updates as the primary change, which is specific enough to convey meaningful information and allows reviewers to quickly understand the nature of the modification.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5125777 and 836f110.

⛔ Files ignored due to path filters (3)
  • packages/colors/bun.lock is excluded by !**/*.lock
  • packages/colors/dist/index.css is excluded by !**/dist/**
  • packages/colors/dist/index.css.map is excluded by !**/dist/**, !**/*.map
📒 Files selected for processing (5)
  • packages/colors/package.json (1 hunks)
  • packages/colors/src/_theme-dark--cold.scss (1 hunks)
  • packages/colors/src/_theme-dark--warm.scss (1 hunks)
  • packages/colors/src/_theme-light--cold.scss (1 hunks)
  • packages/colors/src/_theme-light--warm.scss (1 hunks)
🔇 Additional comments (5)
packages/colors/package.json (1)

3-3: Version bump to 2.1.0 is appropriate for color palette updates.

The minor version increment correctly signals non-breaking color refinements across all four theme variants without structural changes to the token API or export surface.

packages/colors/src/_theme-light--cold.scss (1)

110-119: Grey scale OKLCH values are valid and properly ordered.

Lightness progression is monotonic (98.54% → 20.62%), chroma is appropriately minimal for neutral greys, and hue clustering around 250–286° maintains the cool tone intended for the light-cold variant.

packages/colors/src/_theme-dark--warm.scss (1)

110-119: Dark-warm grey scale is well-calibrated for dark theme with warm undertones.

Lightness starts at 95.79% (higher than light-cold's 98.54%, appropriate for dark theme readability), and hue clustering around 100° (warm yellow/gold range) distinguishes the warm variant from cold. All values are syntactically valid and properly ordered.

packages/colors/src/_theme-light--warm.scss (1)

110-119: Light-warm grey scale maintains warm undertones with consistent lightness progression.

Lightness descends monotonically (95.79% → 21.35%), and hue clustering around 90–110° sustains the warm palette. The --grey2 hue value (17.18°, warm-red range) introduces subtle variation and appears intentional for palette depth.

packages/colors/src/_theme-dark--cold.scss (1)

110-119: Dark-cold grey scale correctly mirrors light-cold lightness with cold undertones.

Lightness values are identical to light-cold (98.54% → 20.62%), maintaining consistent scale separation. Hue clustering around 250–286° (cool blue range) sustains the cold variant distinction. All OKLCH values are valid and properly ordered.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@planetabhi planetabhi merged commit 8e7aa82 into main Oct 29, 2025
1 check passed
This was referenced Oct 29, 2025
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@planetabhi